Improving Find in Files performance

Vitalii Dovgan

Hi Notepad++ team!

I’ve created a pull request that improves the Find in Files performance by re-using the existing approach with several optimizations, and thus making it 2…3 times faster.

https://github.com/notepad-plus-plus/notepad-plus-plus/pull/18376

I haven’t invented anything new, just optimized what was already there.
I realize the code review may create an impression that several parts have been completely re-written, but that’s no true.
In fact, the existing code has been refactored by extracting parts of several functions into separate helpers, so these moved blocks of code together with new helpers create an impression of a lot of changes. But if you follow the code logic, or just manually copy-paste the separate helpers into the places where these helpers are called, you’d realize the code flow remains the same.
Please feel free to review and test.
I’m writing here because I’m afraid the longer this pull request remains open, the higher are chances of merge conflicts to appear in the affected files.

PeterJones

@Vitalii-Dovgan ,

Even though you just “moved” stuff, it’s a lot of lines of code changed, from the diff perspective, and Don manually reviews all of that. So it’s not an easy one to review.

And since you didn’t attach the PR to any open Issue (though I’m sure there must be more than one asking for improved FiF performance), it’s probably a low priority in his mind (and I’m surprised he didn’t reject it out of hand. It might be because it came from you that it wasn’t rejected).

I recommend searching out one or more Issues to attach it to.

But yes, I do hope it’s able to be merged before there is a conflict.