Notepad++ release 8.9.8.1

andrecool-68

In Windows 7, there is no confirmation dialog for the “Move file to Recycle Bin” action.
In Windows 10, the confirmation dialog for “Move file to Recycle Bin” is present.

Is this by design, or is it a bug?

Снимок.PNG

donho

@Artur-Harison

I cannot reproduce your issue. Reload the file after some changes in text, it’s still working for me:

Artur Harison

@donho
I uplad file.
I cannot isolate the regression conditions.
But you can repeat his with his file.
Text file for teproduction
Video…

donho

@andrecool-68 said:

In Windows 7, there is no confirmation dialog for the “Move file to Recycle Bin” action.
In Windows 10, the confirmation dialog for “Move file to Recycle Bin” is present.

It’s due to:
https://github.com/notepad-plus-plus/notepad-plus-plus/blob/master/PowerEditor/src/NppIO.cpp#L2357

	winVer winVersion = (NppParameters::getInstance()).getWinVersion();
	bool goAhead = true;
	if (winVersion >= WV_WIN8 || winVersion == WV_UNKNOWN)
	{
		// Windows 8 (and version after?) has no system alert, so we ask user's confirmation
		goAhead = (doDeleteOrNot(fileNamePath) == IDOK);
	}

	if (goAhead)
	{
		...
		if (!MainFileManager.deleteFile(bufferID))
		{
			...

Is this by design, or is it a bug?

So it was by design. However, a modification was added in deleteFile about one year ago, by @xomx :

fileOpStruct.fFlags = FOF_ALLOWUNDO | FOF_NOCONFIRMATION; // FOF_NOCONFIRMATION - prevent possible redundant shell-dlg (Notepad++ uses its own delete-confirmation dlg)

(ref: https://github.com/notepad-plus-plus/notepad-plus-plus/commit/de7aa5ae7afb23a900f243120fefeb7a8a3d6ef2)

That disables the OS popup while calling SHFileOperation.

As a result, I think it’s safe to remove OS detection and display Notepad++ build-in warning dialog unconditionally.

I’ll do a commit to fix it.

donho

donho said:

As a result, I think it’s safe to remove OS detection and display Notepad++ build-in warning dialog unconditionally.

I’ll do a commit to fix it.

The issue is fixed in the master. The fix will be in the next release:
https://github.com/notepad-plus-plus/notepad-plus-plus/commit/ee0106b823575715842e4b45939ee355b8610ecf

donho

@Artur-Harison
Still cannot reproduce your issue with the file you provided.

Before

After

Is it rather a plugin issue?

Coises

@donho said:

Still cannot reproduce your issue with the file you provided.

@Artur-Harison said:
Autodetect encode off

With Audodetect character encoding not checked, Notepad++ sees the file as ANSI.

I think Artur’s complaint is that, after selecting Encoding | UTF-8 and then reloading the file, the explicitly set encoding does not stick; Notepad++ reverts to the encoding it “thinks” the file should be (ANSI).

I don’t know if that counts as a bug or as expected behavior.

Artur Harison

@Coises
1 file in utf-8
2 file opened in utf-8
3 after refresh, file toggled in ANSI
————-
@donho
You don’t need to change the file.
Need just open it and reload from disc.

Strange behavior. If you add spacebar anywere
Problem is gone. If again delete space, problem back. O_o
But it’s work a long 1401 line.
If edit after, problem remain.

All plugs off.
X64
Win10
Auto encode off.

Coises

@Artur-Harison said:

@Coises
1 file in utf-8
2 file opened in utf-8
3 after refresh, file toggled in ANSI

I don’t get quite the same result. If I open your test file, Notepad++ thinks it is “ANSI.” I have to change it to UTF-8 using the Encoding menu.

Strange behavior. If you add spacebar anywere
Problem is gone.

That is almost certainly this bug.

Edit to add:

If I rename your file to new_1_test.xml I get exactly the behavior you describe: it opens as UTF-8 but reloads as ANSI. That is surely a bug.

Artur Harison

@Coises
I think you’re right.
If you are encode utf 8 and safe. And reload. Against it’s be Ansi. But if add one spacebar. Problem is gone, but if again delete spacebar. Problem is back.
XML lang detector problem! ?
—-
File was edited in utf 8 format.
Encoding obey XML in first line of document.
But after reload, bufer reads as ANSI, and ignored specification encoding.